Skip to content

[Attentive] - New Actions #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

[Attentive] - New Actions #3033

merged 2 commits into from
Jul 3, 2025

Conversation

joe-ayoub-segment
Copy link
Contributor

New Actions for Attentive Destination

Testing

Destination in Private beta

@joe-ayoub-segment joe-ayoub-segment requested a review from a team as a code owner June 27, 2025 15:05
@joe-ayoub-segment joe-ayoub-segment self-assigned this Jun 27, 2025
@joe-ayoub-segment
Copy link
Contributor Author

To whoever is deploying this - it first needs to be registered.

This was referenced Jun 27, 2025
Closed
Closed
@github-actions GitHub Actions
Copy link
Contributor

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Attentive, Action Field(s):userIdentifiers,eventType,items
  • Destination: Attentive, Action Field(s):userIdentifiers,properties
  • Destination: Attentive, Action Field(s):userIdentifiers,subscriptionType,locale,signUpSourceId

Add these new fields as optional instead and assume default values in perform or performBatch block.

@itsarijitray
Copy link
Contributor

Hi, Can you check the lint error?

@joe-ayoub-segment joe-ayoub-segment merged commit 4046026 into main Jul 3, 2025
12 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the attentive-new-actions branch July 3, 2025 08:27
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 88.76404% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.61%. Comparing base (dff81c3) to head (b275a8f).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...on-actions/src/destinations/attentive/functions.ts 75.00% 5 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3033      +/-   ##
==========================================
+ Coverage   78.03%   79.61%   +1.58%     
==========================================
  Files        1109     1120      +11     
  Lines       20607    20728     +121     
  Branches     3988     3998      +10     
==========================================
+ Hits        16080    16502     +422     
- Misses       3164     3539     +375     
+ Partials     1363      687     -676

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsarijitray itsarijitray itsarijitray approved these changes

Assignees

@joe-ayoub-segment joe-ayoub-segment

Labels
deploy:push mode:cloud partner-eng-review (cloud) Ready for Release team:segment-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-ayoub-segment @itsarijitray